Remove blocking call in async_update #32
Conversation
|
And...you rock! Thanks for contributing. |
|
@aallen90 Are we ready to cut a new release? |
I think it's close! I'm testing the upgrade and process. So far, the only hiccup is needing to set it up again. It does trigger a "Repair" issue, so at least there is visibility. If there's a risk of being inundated by "my integration stopped working?!?!" comments, it might be worth implementing the Config entry migration. If that's not a concern, this could be ignored. We may find a good PR reference to imitate in past HA release notes under the "Integrations now available to setup from the UI" section.
|
|
Config entry migration would be awesome, but I don't have time to implement this unfortunately. Too many other commitments right now. We will probably have 1000 people updating and then scratch head why integration is breaking in meantime. I turned off Issues for this github repo so it forces them to interact with the community in cases of problems. |
My HA instance (v2024.10.1) lists a warning for the PoolMath integration that a blocking call was detected in
client.py'sasync_updateon line 73.This PR updates the
async_updatefunction to use non-blocking I/O when fetching data from the PoolMath API, using theaiohttplibrary described in the HA dev docs.Tested on 2024.10.1 and confirmed HA no longer logs this warning when
async_updateis called.Happy to rebase if #30 is merged first!